Revert cookie store implementation #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tranchitam wants to merge 1 commit into AsyncHttpClient:master from tranchitam:feature/revert-cookie-store-implementation

tranchitam commented Jul 30, 2018

Motivations:

Cookie store works incorrectly when sending multiple requests having the same URI, the later cookie can override the sooner cookie -> not safe when using redirect.
Don't want to set cookie back when sending new request.

Changes:

CookieStore will be removed completely.
Set cookie from response headers to redirect request

Results:

Set cookie from response headers to redirect request
Don't set cookie when sending new request.

Related issue:


          Revert cookie store implementation

2fb5d5d

Contributor

slandelle commented Jul 30, 2018

No, you can't just remove a feature for the sole reason it doesn't perfectly fit your use case as is.

slandelle closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet